[1.20 regression] narrowing failure with unrelated boolean

[AA-Turner]

Bug Report

Mypy 1.20 and master report an incorrect error that seems to be a failure of type narrowing in the following case:

class FancyInteger(int):
    name = 'fancy'

    def __repr__(self):
        return f'{int(self)}!'

    def __str__(self):
        return f'{int(self)}!'


def stringify(value: object) -> str:
    if isinstance(value, (str, int)) or value is None:
        if value.__class__.__str__ == FancyInteger.__str__ and isinstance(value, FancyInteger):
            return f"{value.__class__.__name__}.{value.name}"
    return str(value)

playground link

This passes in MyPy 1.19.1, and is ostensibly correct code -- this is a minimised version, but the original performs similar checks with enum.StrEnum, so not that esoteric.

If the value.__class__.__str__ == FancyInteger.__str__ comparison is removed, or split to a new if statement, the error fails to reproduce.

To Reproduce

https://mypy-play.net/?mypy=latest&python=3.12&gist=a6f8ba95151fa5e0003273b812d8223e

Expected Behavior

No error

Actual Behavior

$ uvx mypy==1.20
bug.py:14: error: Item "str" of "str | int" has no attribute "name"  [union-attr]
bug.py:14: error: Item "int" of "str | int" has no attribute "name"  [union-attr]
Found 2 errors in 1 file (checked 1 source file)
$ uvx mypy==1.19.1
Success: no issues found in 1 source file

Your Environment

• Mypy version used: 1.20 & 1.19.1
• Mypy command-line flags: None
• Mypy configuration options from mypy.ini (and other config files): None
• Python version used: 3.12 & 3.14

[brianschubert]

Thanks, bisects to ad30be8, cc @hauntsaninja

[AA-Turner]

thanks @brianschubert, amazingly fast!

[hauntsaninja]

Thanks for the issue. I thiiiiiink the change in 1.20 is actually just exposing a pre-existing issue, e.g. something like this fails on mypy 1.19 as well:

class A:
    tag: int

class B:
    tag: int
    name = "b"

class C:
    tag: str

def stringify(value: A | B | C) -> str:
    if isinstance(value.tag, int) and isinstance(value, B):
        reveal_type(value)
        return value.name
    return ""