DataGrid - Fix the browser scrolling back to the grid when data is updated (T1310557) by markallenramirez · Pull Request #33168 · DevExpress/DevExtreme

markallenramirez · 2026-04-06T12:56:31Z

No description provided.

Copilot

Pull request overview

Fixes DataGrid keyboard-navigation focus restoration so that updating data doesn’t cause the browser to scroll the page back to the grid (by using native focus({ preventScroll }) during render completion).

Changes:

Add a preventScroll flag to _updateFocus and _focus and propagate it from renderCompleted.
Replace synthetic eventsEngine.trigger(..., 'focus') with native DOM focus({ preventScroll }) for the focused cell/row.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

This reverts commit 8b4814d.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

…dated (T1310557) (DevExpress#33168) (cherry picked from commit 5316974)

…dated (T1310557) (DevExpress#33168)

markallenramirez self-assigned this Apr 6, 2026

markallenramirez added the 26_1 label Apr 6, 2026

Copilot AI review requested due to automatic review settings April 6, 2026 12:56

Copilot started reviewing on behalf of markallenramirez April 6, 2026 12:57 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

markallenramirez requested a review from a team as a code owner April 7, 2026 08:51

Copilot AI review requested due to automatic review settings April 7, 2026 08:55

Copilot started reviewing on behalf of markallenramirez April 7, 2026 08:56 View session

markallenramirez force-pushed the bug_T1310557/26_1 branch from a9afe9f to d2b9704 Compare April 7, 2026 08:56

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/scrollable_a11y.ts Outdated

Comment thread packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts Outdated

Copilot AI review requested due to automatic review settings April 8, 2026 09:04

Copilot started reviewing on behalf of markallenramirez April 8, 2026 09:05 View session

markallenramirez force-pushed the bug_T1310557/26_1 branch from 9ff69ab to 8b4814d Compare April 8, 2026 09:06

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts

Copilot AI review requested due to automatic review settings April 8, 2026 12:36

markallenramirez force-pushed the bug_T1310557/26_1 branch from 4080b45 to 6d35176 Compare April 8, 2026 12:36

Copilot started reviewing on behalf of markallenramirez April 8, 2026 12:37 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js Outdated

Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js Outdated

Copilot AI review requested due to automatic review settings April 10, 2026 08:03

markallenramirez force-pushed the bug_T1310557/26_1 branch from ecf7496 to 36c670d Compare April 10, 2026 08:03

Copilot started reviewing on behalf of markallenramirez April 10, 2026 08:04 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js Outdated

markallenramirez added 8 commits April 14, 2026 14:38

spike

823933c

fix

4e17641

additional fix

56f8b60

typings

9f4588f

testcafe

86d4cad

Revert "testcafe"

b901b20

This reverts commit 8b4814d.

qunit

dc7c5ef

update fix

7929e7a

markallenramirez added 2 commits April 14, 2026 14:38

update test

d848ca1

update test

c360e41

Copilot AI review requested due to automatic review settings April 14, 2026 06:38

markallenramirez force-pushed the bug_T1310557/26_1 branch from 096a9c9 to c360e41 Compare April 14, 2026 06:38

Copilot started reviewing on behalf of markallenramirez April 14, 2026 06:39 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/focus.integration.tests.js

Raushen reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts Outdated

Raushen reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts Outdated

Raushen reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/grids/grid_core/keyboard_navigation/m_keyboard_navigation.ts

update fix

8c70e5d

Raushen approved these changes Apr 15, 2026

View reviewed changes

markallenramirez merged commit 5316974 into DevExpress:26_1 Apr 15, 2026
103 checks passed

markallenramirez added a commit to markallenramirez/DevExtreme that referenced this pull request Apr 15, 2026

DataGrid - Fix the browser scrolling back to the grid when data is up…

ea2c72a

…dated (T1310557) (DevExpress#33168) (cherry picked from commit 5316974)

This was referenced Apr 15, 2026

DataGrid - Fix the browser scrolling back to the grid when data is updated (T1310557) #33277

Merged

DataGrid - Fix the browser scrolling back to the grid when data is updated (T1310557) #33278

Merged

markallenramirez added a commit to markallenramirez/DevExtreme that referenced this pull request Apr 15, 2026

DataGrid - Fix the browser scrolling back to the grid when data is up…

14540c0

…dated (T1310557) (DevExpress#33168) (cherry picked from commit 5316974)

ajivanyandev pushed a commit to ajivanyandev/DevExtreme that referenced this pull request Apr 15, 2026

DataGrid - Fix the browser scrolling back to the grid when data is up…

6b3b05f

…dated (T1310557) (DevExpress#33168)

markallenramirez deleted the bug_T1310557/26_1 branch April 15, 2026 10:26

Conversation

markallenramirez commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants