Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates build and CI-related scripts to reduce audit alerts and improve determinism by switching away from ad-hoc installs (npm i, npx) toward lockfile-based / workspace-managed execution, and removes unused GitHub Action scaffolding.
Changes:
- Switched documentation injection install step to
npm cifor reproducible installs. - Replaced several
npx ...usages withpnpm exec ...in nx-infra-plugin build flow and internal scripts. - Removed the unused
setup-chrome-headless-shellcomposite action and related commented-out references.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Uses npm ci when installing deps in the cloned documentation repo. |
| packages/nx-infra-plugin/src/executors/generate-components/angular-generator.ts | Tweaks error message when devextreme-internal-tools is missing. |
| packages/nx-infra-plugin/scripts/build.ts | Uses pnpm exec tsc instead of npx tsc for compilation. |
| packages/nx-infra-plugin/package.json | Switches scripts from npx to pnpm exec for ts-node/nx. |
| packages/devextreme/js/__internal/grids/docs/scripts/data_grid/generate.ts | Updates the suggested command for running the prerequisite generator. |
| apps/angular/src/polyfills.ts | Removes outdated “npm install --save …” hints in commented polyfill imports. |
| .github/actions/setup-chrome-headless-shell/action.yml | Deleted unused composite action that installed chrome-headless-shell. |
| .github/actions/run-qunit-tests/action.yml | Removes commented-out steps referencing the deleted chrome setup action. |
packages/nx-infra-plugin/src/executors/generate-components/angular-generator.ts
Outdated
Show resolved
Hide resolved
| console.error(`ERROR: grid_core_architecture.generated.json not found at ${GC_JSON_PATH}`); | ||
| console.error('Please run the grid_core architecture script first:'); | ||
| console.error(' npx tsx __docs__/scripts/grid_core/generate.ts --json'); | ||
| console.error(' pnpm exec tsx __docs__/scripts/grid_core/generate.ts --json'); |
There was a problem hiding this comment.
This guidance now suggests pnpm exec tsx ..., but tsx does not appear to be a dependency in this repo (so pnpm exec tsx is likely to fail). Prefer a command that works without preinstalling tsx (e.g. npx tsx ... or pnpm dlx tsx ...), or ensure tsx is added as a devDependency where this script is expected to run.
Suggested change
| console.error(' pnpm exec tsx __docs__/scripts/grid_core/generate.ts --json'); | |
| console.error(' pnpm dlx tsx __docs__/scripts/grid_core/generate.ts --json'); |
IlyaKhD
previously approved these changes
Apr 13, 2026
packages/devextreme/js/__internal/grids/__docs__/scripts/data_grid/generate.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.