typing(aggregation): Add type hint to (gramian_)weighting fields#651
Merged
ValerianRey merged 2 commits intomainfrom Apr 16, 2026
Merged
typing(aggregation): Add type hint to (gramian_)weighting fields#651ValerianRey merged 2 commits intomainfrom
ValerianRey merged 2 commits intomainfrom
Conversation
ValerianRey
added
package: aggregation
cc: typing
github-actions
bot
changed the title
- This is needed in order to use the weighting as a type hint for a field of the aggregator
ValerianRey
force-pushed
the
add-missing-type-hints
branch
from
1f7c82b to
eddd329
Compare
Contributor
Author
|
Merging because we agreed on this. Feel free to tell me if you changed your mind @PierreQuinton |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These types seem to not be inferred automatically by the type checker, so they're necessary in order to make setters on the aggregators that will affect the inner weighting too.