fix: UI layout breaks + keyboard shortcuts follow macOS HIG (#702)#720
Merged
fix: UI layout breaks + keyboard shortcuts follow macOS HIG (#702)#720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two-part fix for #702: resolves UI layout breaks from menu interactions AND updates default keyboard shortcuts to follow macOS Human Interface Guidelines.
Part 1: UI Layout Fixes (12 causes addressed)
bounds.height > 0, defer collapse, clamp constraintsQuerySplitView.swift.transaction { $0.animation = nil }blocks animation from NSSplitViewContentView.swift.transitionand.animation(instant toggle)MainEditorContentView.swiftwithAnimationat call site instead of view modifierMainContentCommandActions.swiftMainContentView+Helpers.swiftTask { @MainActor }instead ofDispatchQueue.main.asyncDataGridView.swift,+Editing,+Selection,DataGridCoordinatorMainContentView.swiftTableProApp.swift@MainActor+ 50ms sleepSQLEditorCoordinator.swiftattachmentAnchor: .point(.bottom)TableProToolbarView.swiftPart 2: Keyboard Shortcut Defaults
Updated 6 defaults to follow macOS HIG. Existing user customizations are preserved.
⌘F⌘⇧F⌘Fis "Find" (macOS HIG)⌘⇧B⌘⌥I⌘B⌘0⌘⌥C⌘⌃C⌘I⌘⇧N⌘Iis "Get Info" in Finder⌘D⌘⇧D⌘Dconflicts with "Select Word"Test plan
⌘0) — sidebar toggles without layout glitch⌘⌥I) — inspector appears without NSSplitView jitter⌘⇧F) — filter panel appears instantly (no slide)⌘Fin SQL editor — Find panel opens (not filter toggle)