Skip to content

feat(other): add basic BankAccount OOP class (v3)#14549

Open
nickzerjeski wants to merge 5 commits intoTheAlgorithms:masterfrom
nickzerjeski:renew-bank-account-14024-v2
Open

feat(other): add basic BankAccount OOP class (v3)#14549
nickzerjeski wants to merge 5 commits intoTheAlgorithms:masterfrom
nickzerjeski:renew-bank-account-14024-v2

Conversation

@nickzerjeski
Copy link
Copy Markdown

Describe your change:

Fixes #14024

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Copilot AI review requested due to automatic review settings April 13, 2026 09:13
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Apr 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new BankAccount class under other/ intended to demonstrate basic OOP concepts (encapsulation via properties, simple state updates) and includes inline doctests.

Changes:

  • Introduces BankAccount with validated initialization, balance accessor, deposit(), and withdraw().
  • Adds doctest examples in the class docstring and a __main__ doctest runner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Apr 13, 2026
nickzerjeski and others added 4 commits April 14, 2026 10:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nickzerjeski
Copy link
Copy Markdown
Author

@copilot apply changes based on the comments in this thread

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Apr 14, 2026
Copy link
Copy Markdown

@kbtale kbtale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

3 participants