Merged
Conversation
Updating to use OIDC
added update NPM
cellog
reviewed
Apr 10, 2026
.github/workflows/ci.yml
Outdated
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Update npm | ||
| run: sudo npm install -g npm@latest |
There was a problem hiding this comment.
strongly recommend pinning this to a specific version and regularly updating so we don't fall prey to supply chain attacks if npm gets hacked
Contributor
Author
There was a problem hiding this comment.
@cellog good call I just copied over the fern recommendation for the CI
There was a problem hiding this comment.
yeah I saw that in the docs, no worries.
side note: that, in a nutshell, is why AI makes so many questionable recommendations: the official docs often make questionable recommendations and it was trained on that stuff 😂.
Contributor
Author
There was a problem hiding this comment.
So true haha updated now!
cellog
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to use OIDC