Missing escaping for XML error message #65047

[maheshpatel27]

Add escaping src/wp-trackback.php

if ( $error ) {

echo '<?xml version="1.0" encoding="utf-8"?' . ">\n";
echo "\n";
echo "1\n";
echo "" . esc_html ( $error_message ) . "\n";
echo '';

}

Trac ticket: https://core.trac.wordpress.org/ticket/65047#ticket

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @maheshpatel27.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Hi @maheshpatel27! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

• PHP Coding Standards
• CSS Coding Standards
• HTML Coding Standards
• JavaScript Coding Standards
• Accessibility Coding Standards
• Inline Documentation Standards

Thank you,
The WordPress Project

[pbiron]

I agree with @sabernhardt in his comment on the ticket that esc_xml() would better here than esc_html()

[sabernhardt]

switching the function, and removing a space after the function name:

Suggested change

	echo "<message>" . esc_html ( $error_message ) . "</message>\n";
	echo "<message>" . esc_xml( $error_message ) . "</message>\n";