Style enqueue correction for RTL languages#11537
Style enqueue correction for RTL languages#11537vishalsingh098 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @vishal-xecurify. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/61625
Changed line : wp_style_add_data( $style_handle_name, 'suffix', $suffix );
to:
wp_style_add_data( $style_handle_name, 'suffix', $is_core_block ? $suffix : '' );
Non-core blocks never use .min in their filenames, so storing a non-empty suffix caused WP_Styles::do_item() to search for ".min.css" in a URL that only has ".css", silently leaving the LTR URL unchanged on RTL sites.
[tests/phpunit/tests/blocks/register.php] — tests:
Added @ticket 61625 to the existing RTL test
Added a new dedicated test test_register_block_style_handle_rtl_suffix_is_empty_for_non_core_blocks that explicitly documents the requirement and will catch any regression
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.