Exclude 3.14 ML containers from push314#38221
Exclude 3.14 ML containers from push314#38221jrmccluskey wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modifies the build configuration to prevent the attempt to push ML-specific containers for Python 3.14. This change is necessary because the required dependencies, such as compatible TensorFlow releases, are not yet available for this version of Python. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle build configuration for Python containers to exclude Python 3.14 from ML-related tasks since dependencies are not yet available. Feedback suggests using a numeric comparison with the loop index instead of a string comparison to improve robustness and ensure future Python versions are handled correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38221 +/- ##
============================================
- Coverage 56.74% 56.73% -0.01%
Complexity 3427 3427
============================================
Files 1182 1182
Lines 188797 188800 +3
Branches 3593 3593
============================================
- Hits 107126 107124 -2
- Misses 78278 78283 +5
Partials 3393 3393
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
3.14 ML containers do not exist yet (no tensorflow release compatible with 3.14 among other things) so we need to exclude a 3.14 ML container from the push commands.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.