Soft delete port forwarding, load balancing and firewall rules#13015
Draft
bernardodemarco wants to merge 1 commit intoapache:mainfrom
Draft
Soft delete port forwarding, load balancing and firewall rules#13015bernardodemarco wants to merge 1 commit intoapache:mainfrom
bernardodemarco wants to merge 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@blueorangutan package |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13015 +/- ##
=========================================
Coverage 17.95% 17.95%
Complexity 16502 16502
=========================================
Files 6019 6019
Lines 540743 540771 +28
Branches 66255 66256 +1
=========================================
+ Hits 97082 97090 +8
- Misses 432720 432741 +21
+ Partials 10941 10940 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@blueorangutan package |
|
@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when port forwarding, load balancing and firewall rules are removed, their records are permanently deleted from the database. This makes it impossible to track and audit previously applied rules after their removal.
Therefore, this PR proposes to, instead of deleting the records associated with such network rules, only marking them as removed. To achieve that, a
removedcolumn has been added to the tables that store the rules metadata, allowing to track the exact date and time when a rule was removed.Maintaining these records is essential for auditing and traceability purposes. It ensures that historical network configurations remain accessible for cloud administrators/operators, enabling proper investigation, compliance verification and analysis of past behavior, even after rules are no longer active.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Egress rules (ER)
Records persisted in the database after the tests
Firewall (FW)
Records persisted in the database after the tests
Port forwarding (PF)
Records persisted in the database after the tests
Public Load balancing (LB)
Records persisted in the database after the tests
Internal Load balancing (LB)
Records persisted in the database after the tests