feat[expr-common]: add REE arithmetic coercion for numeric and decimal#21179
Open
asubiotto wants to merge 1 commit intoapache:mainfrom
Open
feat[expr-common]: add REE arithmetic coercion for numeric and decimal#21179asubiotto wants to merge 1 commit intoapache:mainfrom
asubiotto wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
Contributor
Author
|
Friendly ping for a review or triage @alamb |
Jefffrey
reviewed
Apr 16, 2026
Contributor
Jefffrey
left a comment
Jefffrey
left a comment
There was a problem hiding this comment.
Do we have an end to end (e.g. SQL in SLT) test that can confirm this behaviour? Or is it blocked by missing support for REE elsewhere in the codebase?
Contributor
Author
|
Not sure, happy to take a look and add one if not! |
Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
asubiotto
force-pushed
the
asubiott/reecoercion
branch
from
df80898 to
28afc1a
Compare
Contributor
Author
|
Added, thanks for the suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fix planning error
What changes are included in this PR?
Match arms for REE types
Are these changes tested?
Yes
Are there any user-facing changes?
Queries that would previously return an error on REE columns now pass.