fix: import from datafusion_expr in make_valid_utf8#21687
Merged
Jefffrey merged 1 commit intoapache:mainfrom Apr 17, 2026
Merged
fix: import from datafusion_expr in make_valid_utf8#21687Jefffrey merged 1 commit intoapache:mainfrom
datafusion_expr in make_valid_utf8#21687Jefffrey merged 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-sparkfails to build standalone with-p datafusion-spark#21685.Rationale for this change
Per issue.
make_valid_utf8.rsimports fromdatafusion::logical_expr, butdatafusionis only a dep ofdatafusion-sparkbehind thecorefeature, socargo check -p datafusion-sparkandcargo bench -p datafusion-sparkboth fail without--all-features. CI doesn't catch it becausedatafusion-sqllogictestpinsdatafusion-sparkwithcoreon.What changes are included in this PR?
Move the
ColumnarValue,Signature,Volatilityimports fromdatafusion::logical_exprtodatafusion_expr, which is already imported a few lines below.Are these changes tested?
Covered by existing tests. Verified
cargo check -p datafusion-spark,cargo check -p datafusion-spark --all-targets, andcargo bench -p datafusion-sparkall succeed after the change, and./dev/rust_lint.shpasses.Are there any user-facing changes?
No.