HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly#7952
HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly#7952PDavid wants to merge 6 commits intoapache:masterfrom
Conversation
|
Hmm, it seems that the |
Seems still the same error. |
|
This is the log console output, seems we have already used the new config? |
|
Oh wait a minute, what is the syntax for passing multiple ignore files in? |
|
Strange, it is comma separated... @ndimiduk do you have any ideas on this? |
|
Maybe we need space separator, let's see. 🙈 |
2189d32 to
d554370
Compare
|
Many thanks @ndimiduk for your fix in Yetus! 👍 I guess we will have to wait until the new Yetus release and then upgrade Yetus in HBase, right? |
Yes, unfortunately. Maybe you can re-implement the fix as a function override in our personality file -- bash is extremely monkey-patchable. |
d554370 to
140bee9
Compare
|
Hi @ndimiduk, I tried to do the monkey-patching thing but to be honest I'm not sure if I'm doing it right. It does not work for sure. I cannot see my newly added debug messages in the output log. 🙈 Can you please help in this a bit? |
…k in nightly The author check fails in nightly build: ``` hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule. hbase-website/public/book.html:40827:<p>Also, no <code>@author</code> tags - that’s a rule.</p> ``` Ignore files under hbase-website in author checks.
YETUS-1266 Escape regex metacharacters in author plugin ignore list The author_postcompile function writes --author-ignore-list entries directly into a grep -E filter file without escaping. Filenames containing regex metacharacters (parentheses, brackets, etc.) are silently misinterpreted as pattern syntax, causing those files to pass through unfiltered.
7b44079 to
b2c2a55
Compare
fa87a7e to
23ba7a8
Compare
The author check fails in nightly build:
https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1420/General_20Nightly_20Build_20Report/
Fix:
Ignore files under hbase-website in author checks.