AXON-2010 Added feedback buttons for when thinking box appears only#1759
Open
Migelangel04 wants to merge 2 commits intomainfrom
Open
AXON-2010 Added feedback buttons for when thinking box appears only#1759Migelangel04 wants to merge 2 commits intomainfrom
Migelangel04 wants to merge 2 commits intomainfrom
Conversation
The copy button is now only rendered when there is content to be copied
Migelangel04
requested review from
BHulovatyi,
Blastoplex,
amarg-at,
asifmujteba,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
cindy-atl,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian,
sky-ocean-spirits,
ssinha2598 and
teg-atlassian
as code owners
…ith-text-the-rendering-is-weird
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy button is now only rendered when there is content to be copied
What Is This Change?
When the thinking box was the only response in the chat, there would be no feedback and copy buttons. While it was intentional to not show the copy button for no content, we still want the feedback buttons (and the copy button if there is content to be copied).
Now:
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations:
Rovo Dev code review: Rovo Dev couldn't review this pull request
Upgrade to Rovo Dev Standard to continue using code review.