Run HTTP/2 integration tests against local Caddy instead of nghttp2.org#482
Merged
Run HTTP/2 integration tests against local Caddy instead of nghttp2.org#482
Conversation
The tests hitting nghttp2.org/httpbin/ had been failing on every CI run because the upstream httpbin backend behind nghttpx returns 502 to GitHub Actions runners. Enable h2c on the Caddy docker service (via a new HTTPBIN_H2C_PORT, default 8081, since the existing HTTPBIN_HTTP_PORT mapping goes directly to httpbin), point the TCP h2c test at it, and drop the duplicate "nghttp2.org/httpbin" describe block (ping and GET are already covered by the local "httpbin.org" block).
Coverage Report for CI Build 0Coverage decreased (-0.1%) to 87.636%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
The twitter.com describe block was using @moduletag instead of
@describetag, which made its connect: {"twitter.com", 443} tag apply
to the whole module. That caused the top-level setup to open an HTTPS
connection to twitter.com even for tests outside the describe (like
the TCP h2c test), and the SSL socket's SETTINGS frame would land in
the test mailbox. The previous test had a swallow-hack comment about
"SSL messages sneaking in"; this removes the root cause.
ericmj
commented
Apr 16, 2026
| end | ||
| end | ||
|
|
||
| describe "nghttp2.org/httpbin" do |
Member
Author
There was a problem hiding this comment.
These tests duplicated mint code paths already covered by the "httpbin.org" describe block (local Caddy over HTTPS/h2): HTTP2.ping/1 and HTTP2.request/5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests hitting nghttp2.org/httpbin/ had been failing on every CI run because the upstream httpbin backend behind nghttpx returns 502 to GitHub Actions runners. Enable h2c on the Caddy docker service (via a new HTTPBIN_H2C_PORT, default 8081, since the existing HTTPBIN_HTTP_PORT mapping goes directly to httpbin), point the TCP h2c test at it, and drop the duplicate "nghttp2.org/httpbin" describe block (ping and GET are already covered by the local "httpbin.org" block).