Fix unused parameter warnings in conversions.h (#56472)#56472
Open
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Open
Fix unused parameter warnings in conversions.h (#56472)#56472christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101108449. |
meta-codesync
bot
changed the title
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 16, 2026
Summary: Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
a8b6520 to
51cc936
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 16, 2026
Summary: Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
51cc936 to
520995f
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 16, 2026
Summary: Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
520995f to
0559c25
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 16, 2026
Summary: Pull Request resolved: facebook#56472 Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
0559c25 to
ba6feb6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 16, 2026
Summary: Pull Request resolved: facebook#56472 Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
ba6feb6 to
212e561
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 17, 2026
Summary: Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
212e561 to
d7d0fd3
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 17, 2026
Summary: Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
d7d0fd3 to
a931cad
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Apr 17, 2026
Summary: Pull Request resolved: facebook#56472 Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
a931cad to
32e5ddb
Compare
Summary: Pull Request resolved: facebook#56472 Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D101108449
christophpurrer
force-pushed
the
export-D101108449
branch
from
32e5ddb to
cc0c4f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix clang-diagnostic-unused-parameter warnings by commenting out the unused 'context' parameter in two fromRawValue functions. This maintains API compatibility while resolving the lint warnings.
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D101108449