Skip to content

[Fiber][enableYieldingBeforePassive] Enable in experimental builds again#36278

Draft
eps1lon wants to merge 2 commits intofacebook:mainfrom
eps1lon:sebbie/04-15-_fiber_enableyieldingbeforepassive_enable_in_experimental_builds_again
Draft

[Fiber][enableYieldingBeforePassive] Enable in experimental builds again#36278
eps1lon wants to merge 2 commits intofacebook:mainfrom
eps1lon:sebbie/04-15-_fiber_enableyieldingbeforepassive_enable_in_experimental_builds_again

Conversation

@eps1lon
Copy link
Copy Markdown
Collaborator

@eps1lon eps1lon commented Apr 15, 2026

@meta-cla meta-cla bot added the CLA Signed label Apr 15, 2026
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Apr 15, 2026
@react-sizebot
Copy link
Copy Markdown

react-sizebot commented Apr 15, 2026

Comparing: bf45a68...4afd2b0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 612.91 kB 612.91 kB = 108.30 kB 108.30 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.17% 678.85 kB 679.98 kB = 119.27 kB 119.19 kB
facebook-www/ReactDOM-prod.classic.js +0.08% 698.58 kB 699.12 kB +0.10% 122.74 kB 122.86 kB
facebook-www/ReactDOM-prod.modern.js +0.08% 688.90 kB 689.43 kB +0.10% 121.12 kB 121.25 kB
react-native/shims/ReactNative.js New file 0.00 kB 0.60 kB New file 0.00 kB 0.34 kB
react-native/shims/ReactNativeTypes.js +18.74% 5.99 kB 7.11 kB +9.82% 1.81 kB 1.99 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/shims/ReactNative.js New file 0.00 kB 0.60 kB New file 0.00 kB 0.34 kB
react-native/shims/ReactNativeTypes.js +18.74% 5.99 kB 7.11 kB +9.82% 1.81 kB 1.99 kB
test_utils/ReactAllWarnings.js +0.40% 68.30 kB 68.58 kB +0.56% 17.17 kB 17.27 kB
react-native/implementations/ReactFabric-dev.js +0.37% 777.57 kB 780.44 kB +0.45% 124.63 kB 125.19 kB
react-native/implementations/ReactFabric-dev.fb.js +0.36% 814.86 kB 817.78 kB +0.42% 130.49 kB 131.03 kB
oss-experimental/react-art/cjs/react-art.development.js = 737.84 kB 734.98 kB = 116.06 kB 115.53 kB

Generated by 🚫 dangerJS against 4afd2b0

@eps1lon eps1lon force-pushed the sebbie/04-15-_fiber_enableyieldingbeforepassive_enable_in_experimental_builds_again branch from a69a3c4 to 4afd2b0 Compare April 17, 2026 12:02
Comment on lines -3760 to -3761
// Passive effects.
await waitForPaint([]);
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without any actual Component, React skipped directly to prerendering the hidden Activity. I added a Function Component with passive Effects to make it clear that there is a yield between Passive Effects and prerendering. Though not without the flag which seems like a bug fixed by the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants