Remove legacy Paper renderer shim cleanup from artifact commit workflow#36297
Merged
rubennorte merged 1 commit intomainfrom Apr 17, 2026
Merged
Remove legacy Paper renderer shim cleanup from artifact commit workflow#36297rubennorte merged 1 commit intomainfrom
rubennorte merged 1 commit intomainfrom
Conversation
PR #36285 deleted the Paper (legacy) renderer, including the shim file ReactNative.js. The artifact commit workflow still tries to rm this file, which fails and blocks the entire pipeline since April 16.
|
Comparing: 77319e2...ee82a06 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rubennorte
approved these changes
Apr 17, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…ow (#36297) ## Summary PR #36285 deleted the Paper (legacy) renderer, including the shim file `scripts/rollup/shims/react-native/ReactNative.js`. However, the `runtime_commit_artifacts` workflow still tries to `rm` this file after moving build artifacts into `compiled-rn/`. Since the file no longer exists in the build output, `rm` (without `-f`) fails and kills the entire step. This has caused **every run of the Commit Artifacts workflow to fail since #36285 landed on April 16**, blocking both `builds/facebook-www` and `builds/facebook-fbsource` branches from receiving new build artifacts. This in turn blocks DiffTrain from syncing React changes into Meta's internal monorepo. DiffTrain build for [bf45a68](bf45a68)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…ow (#36297) ## Summary PR #36285 deleted the Paper (legacy) renderer, including the shim file `scripts/rollup/shims/react-native/ReactNative.js`. However, the `runtime_commit_artifacts` workflow still tries to `rm` this file after moving build artifacts into `compiled-rn/`. Since the file no longer exists in the build output, `rm` (without `-f`) fails and kills the entire step. This has caused **every run of the Commit Artifacts workflow to fail since #36285 landed on April 16**, blocking both `builds/facebook-www` and `builds/facebook-fbsource` branches from receiving new build artifacts. This in turn blocks DiffTrain from syncing React changes into Meta's internal monorepo. DiffTrain build for [bf45a68](bf45a68)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #36285 deleted the Paper (legacy) renderer, including the shim file
scripts/rollup/shims/react-native/ReactNative.js. However, theruntime_commit_artifactsworkflow still tries tormthis file aftermoving build artifacts into
compiled-rn/. Since the file no longerexists in the build output,
rm(without-f) fails and kills theentire step.
This has caused every run of the Commit Artifacts workflow to fail since #36285 landed on April 16, blocking both
builds/facebook-wwwandbuilds/facebook-fbsourcebranches from receiving new build artifacts. This in turn blocks DiffTrain from syncing React changes into Meta's internal monorepo.