Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the prerelease_deps and mypy sessions in noxfile.py, which were previously skipped or commented out. The prerelease_deps session now runs unit and system tests, and the mypy session is fully configured with its own dependencies and execution steps. Feedback includes a correction to the --exclude flag in the mypy command to ensure the regex is interpreted correctly by removing internal quotes, as well as a suggestion to use a version constant instead of a hardcoded Python version for better maintainability.
| os.path.join("tests", "unit"), | ||
| "--check-untyped-defs", | ||
| "--explicit-package-bases", | ||
| '--exclude="^third_party"', |
There was a problem hiding this comment.
The --exclude flag contains literal double quotes within the string ("^third_party"). Since session.run passes arguments directly to the executable without shell interpretation, these quotes will be treated as part of the regular expression, likely causing it to fail to match the intended third_party directory. It should be passed without the internal quotes.
| '--exclude="^third_party"', | |
| "--exclude=^third_party", |
packages/bigframes/noxfile.py
Outdated
|
|
||
| @nox.session(python=DEFAULT_PYTHON_VERSION) | ||
| # NOTE: this is the mypy session that came directly from the bigframes split repo | ||
| @nox.session(python="3.10") |
There was a problem hiding this comment.
Hardcoding python="3.10" for the mypy session is less flexible than using a version constant like DEFAULT_PYTHON_VERSION or ALL_PYTHON[-1], which are used elsewhere in this file. Unless there is a specific requirement to run type checks only on Python 3.10, consider using the project's default Python version for consistency and easier maintenance.
| @nox.session(python="3.10") | |
| @nox.session(python=DEFAULT_PYTHON_VERSION) |
…ke prerelease.cfg
… running no_extras nightly
…ence to running system_prerel nightly
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Fixes b/501166036 Fixes #16081
This migrates google-area120-tables and google-cloud-config to librarian.
Implements Search functionality: - new `search` stage - `between` expression (as alias for `And(GreaterThanOrEqual(x), LessThanOrEqual(y)`) - `geo_distance` expression (for use in search stages only) - `Score()` expression (for use in search stages only) - SocumentMatches expression (for use in search stages only)
New Expressions: - offset - nor - coalesce - switch_on - array_filter - array_transform - storage_size Restructured how custom repr() strings are build, to accommodate complexities in array_transform Note: parent and reference_slice will be added in a future PR. More detailed changes will be needed to support arbitrary collection/database references; currently only document references are supported
Internal Bug: b/502172684
…16617) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-cloud-python/issues) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
Misc changes in prep for GA release of pipelines:
- re-enable releases for firestore
- remove notes about pipelines being in preview
- added individual beta labels for search/dml classes and methods
- expose options in raw_stage
- renamed Type to PipelineDataType
- moved helper classes (options, enums) into pipeline_types
- expose pipeline classes in top-level \_\_init__.py
… running no_extras nightly
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
7 participants
This PR seeks to enable a number of tests to help ensure full validation.
See #16489 for additional details.