chore(storage): improve type annotations in client and bucket modules#16623
Open
bautsi wants to merge 2 commits intogoogleapis:mainfrom
Open
chore(storage): improve type annotations in client and bucket modules#16623bautsi wants to merge 2 commits intogoogleapis:mainfrom
bautsi wants to merge 2 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces type annotations to the bucket and client modules. The review feedback highlights that the current implementation of these hints causes circular dependencies and runtime NameErrors. The reviewer suggests using string literals for type hints and utilizing TYPE_CHECKING blocks to resolve these issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type annotations to selected methods in the storage client and bucket modules to improve developer experience and static analysis support.
Includes:
google.cloud.storage.Bucket.blob()google.cloud.storage.Bucket.get_blob()google.cloud.storage.Client.get_bucket()google.cloud.storage.Client.create_bucket()No runtime behavior is changed.
Partially addresses #15969