fix(navigation): clean up leaked global scroll listeners#7617
Open
Manishnemade12 wants to merge 2 commits intolayer5io:masterfrom
Open
fix(navigation): clean up leaked global scroll listeners#7617Manishnemade12 wants to merge 2 commits intolayer5io:masterfrom
Manishnemade12 wants to merge 2 commits intolayer5io:masterfrom
Conversation
Signed-off-by: Manishnemade12 <mnemade140@gmail.com>
7696134 to
759f0d3
Compare
Signed-off-by: Manish Nemade <166635137+Manishnemade12@users.noreply.github.com> Signed-off-by: Manishnemade12 <mnemade140@gmail.com>
51d2108 to
9420343
Compare
rishiraj38
approved these changes
Apr 11, 2026
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes memory leaks caused by uncleaned global
scrolllisteners in SPA navigation flows.Closes : #7611
Root Cause
Two components attached
window.addEventListener("scroll", ...)using anonymous callbacks insideuseEffectwithout corresponding cleanup, so listeners accumulated across route transitions.What Changed
handleScrollfunction and cleanup return insrc/sections/General/Navigation/index.js.handleHeaderScrollfunction and cleanup return insrc/sections/Company/Brand/index.js.Why This Fix
Using stable function references allows
window.removeEventListener(...)on unmount, preventing stacked listeners, memory leaks, and scroll-jank over long sessions.Validation
scroll/resizelisteners acrosssrc/**.