fix(test): preserve full stack traces in test.step with POM and Promise.all#40167
Open
ishanrajsingh wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(test): preserve full stack traces in test.step with POM and Promise.all#40167ishanrajsingh wants to merge 1 commit intomicrosoft:mainfrom
ishanrajsingh wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #40141
Problem
Stack traces are truncated when using
test.stepinside Page Object Model (POM) methods,especially when combined with
Promise.all.User-land stack frames (e.g. POM methods and test file calls) were missing,
making debugging difficult.
Root Cause
Stack traces were being overwritten in intermediate step handling:
_addStep.complete_failWithErrorThis removed original async stack frames.
Fix
_failWithError(final error pipeline)_addStep.completestackTrace.tsResult
Stack traces now correctly include:
shouldBeCorrect,shouldBeValidColor)test.step)JavaScript async limitations (e.g.
Promise.all) may still omit some parent frames,but Playwright no longer truncates or removes user-land stack traces.
Validation