test(cli): add kill-all coverage with pid filter#40170
Merged
pavelfeldman merged 1 commit intomicrosoft:mainfrom Apr 11, 2026
Merged
test(cli): add kill-all coverage with pid filter#40170pavelfeldman merged 1 commit intomicrosoft:mainfrom
pavelfeldman merged 1 commit intomicrosoft:mainfrom
Conversation
Adds a test-only env var (PLAYWRIGHT_KILL_ALL_PID_FILTER_FOR_TEST) that narrows kill-all to a specific set of pids so tests don't kill unrelated daemons. Switches the POSIX path to ps auxww so long command lines aren't truncated and the matcher actually finds them. Adds the corresponding tests for both `cli open` and `cli show`. `cli show` now prints its dashboard pid behind another test-only env var so the test can capture it.
yury-s
approved these changes
Apr 11, 2026
Contributor
Test results for "MCP"1 failed 6506 passed, 383 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLAYWRIGHT_KILL_ALL_PID_FILTER_FOR_TESTthat narrowskill-allto specific pids so tests don't kill unrelated daemons.ps auxwwso long daemon command lines aren't truncated by terminal width.cli showprints its dashboard pid (gated onPLAYWRIGHT_PRINT_DASHBOARD_PID_FOR_TEST) so tests can capture it.tests/mcp/cli-killall.spec.tscovering bothcli openandcli show.