chore: retry downloads on retryable errors#3298
Open
dsanders11 wants to merge 1 commit intonodejs:mainfrom
Open
chore: retry downloads on retryable errors#3298dsanders11 wants to merge 1 commit intonodejs:mainfrom
dsanders11 wants to merge 1 commit intonodejs:mainfrom
Conversation
Contributor
Author
|
Test failures for "Lint Python" and "Test Pack" seem unrelated and preexisting in CI. |
Assisted-by: Claude Opus 4.6 Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
dsanders11
force-pushed
the
retry-download
branch
from
ff0d21c to
8abd342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
Fixes #2847
Retries downloads up to 3 times to ensure a transient network error (we've seen
ECONNRESETfrom time to time) doesn't cause the whole thing to fail.make-fetch-happenmakes it easy to retry for retryable errors (including 429 and 500 response status codes), and I've added test coverage to validate the behavior.