Skip to content

feat: support echo v5#48

Open
jinuthankachan wants to merge 1 commit intooapi-codegen:mainfrom
jinuthankachan:v5
Open

feat: support echo v5#48
jinuthankachan wants to merge 1 commit intooapi-codegen:mainfrom
jinuthankachan:v5

Conversation

@jinuthankachan
Copy link
Copy Markdown

closes #37

@jinuthankachan jinuthankachan requested a review from a team as a code owner April 14, 2026 05:15
@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedgithub.com/​labstack/​echo/​v5@​v5.1.072100100100100
Addedgithub.com/​getkin/​kin-openapi@​v0.135.074100100100100
Addedgithub.com/​stretchr/​testify@​v1.11.196100100100100

View full report

@jinuthankachan jinuthankachan mentioned this pull request Apr 14, 2026
@mromaszewicz
Copy link
Copy Markdown
Member

@jamietanna - what do you think, should we put echo V5 as a sub-module of echo-middleware or make a repo specifically for it?

The middleware itself, for V4 and V5 is basically identical.

I would love to see both just call through to shared code, but Go's module system makes it annoying since each sub-module requires its own git tag for each release to keep various tools happy, like Renovate.

@@ -0,0 +1,27 @@
module github.com/oapi-codegen/echo-middleware/v5

go 1.26.2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echo works fine with Go 1.25.0 (https://github.com/labstack/echo/blob/v5/go.mod), so I think we should try not to get ahead of it too much to allow as many users as possible to use this package. Lots of people can't update to the latest Go version immediately due to all kinds of internal company bureaucracy.

Copy link
Copy Markdown
Member

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think child Go module is ok but not like this right now - if we do, it'll cause Go module versioning confusion, and can make it seem like it's v5 of this module - I'd say maybe echov5

I agree that a separate repo may not be ideal given the shared code

Also, if we are doing a submodule, this will require we change our release process (which is fine, but calling it out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support echo/v5

3 participants