transforms should respect *z* series specified as {value: z}#2272
Open
transforms should respect *z* series specified as {value: z}#2272
Conversation
Fil
changed the title
Fil
changed the title
Fil
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Fil
commented
Apr 15, 2026
| export function maybeZ({z, fill, stroke} = {}) { | ||
| if (z === undefined) [z] = maybeColorChannel(fill); | ||
| if (z === undefined) [z] = maybeColorChannel(stroke); | ||
| if (isOptions(z)) z = z.value; |
Contributor
Author
There was a problem hiding this comment.
Note: other properties on the options z could be:
- scale — which scale to use
- label — a label for axes/legends
- hint — internal hints (e.g., {length: true} for stack)
- filter — a filter function for the channel
- optional — whether the channel can be null
none of these matter to determine how to group series.
Fil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When z is specified as
stroke: {value: "series"}, it should not be ignored by the window (map) transform, the stack ordering, and the select transform.