USHIFT-6715: Enable building multiple bootc blueprint layers in parallel#6489
USHIFT-6715: Enable building multiple bootc blueprint layers in parallel#6489vanhalenar wants to merge 7 commits intoopenshift:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@vanhalenar: This pull request references USHIFT-6715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (29)
WalkthroughThe changes extend bootc image build infrastructure to support combined el9 and el10 layer sets in CI builds. The CI build script now uses per-OS layer1-base blueprints and conditionally adds release-specific builds, while switching non-CI builds to single invocations with comma-separated layer values. The Python utility adds explicit support for processing multiple layer directories in a single invocation with per-directory validation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vanhalenar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
vanhalenar
force-pushed
the
build_bootc_upgrades
branch
from
fca82e1 to
4bc7f1c
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@vanhalenar: This pull request references USHIFT-6715 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vanhalenar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| help="Only build images of the specified type.") | ||
| dirgroup = parser.add_mutually_exclusive_group(required=False) | ||
| dirgroup.add_argument("-l", "--layer-dir", type=str, help="Path to the layer directory to process.") | ||
| dirgroup.add_argument("-l", "--layer-dir", type=str, help="Path to the layer directory to process. Accepts comma-separated list of directories.") |
There was a problem hiding this comment.
How about using action="append"?
From the docs:
>>> parser = argparse.ArgumentParser()
>>> parser.add_argument('--foo', action='append', default=['0'])
>>> parser.parse_args('--foo 1 --foo 2'.split())
Namespace(foo=['0', '1', '2'])
| dirgroup.add_argument("-l", "--layer-dir", type=str, help="Path to the layer directory to process. Accepts comma-separated list of directories.") | |
| dirgroup.add_argument("-l", "--layer-dir", action="append", default=[], help="Path to the layer directory to process. Can be specified multiple times.") |
and then:
$ ./bin/build_bootc_images.sh -l ./image-blueprints-bootc/el9/layer1-base -l ./image-blueprints-bootc/el10/layer1-base
3 participants
Summary by CodeRabbit
New Features
Chores