Skip to content

USHIFT-6853: Pin gevent dependency for ai model serving tests#6497

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pacevedom:USHIFT-6853
Apr 14, 2026
Merged

USHIFT-6853: Pin gevent dependency for ai model serving tests#6497
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pacevedom:USHIFT-6853

Conversation

@pacevedom
Copy link
Copy Markdown
Contributor

@pacevedom pacevedom commented Apr 13, 2026

Summary by CodeRabbit

  • Chores
    • Updated test environment dependencies to include an additional Python package alongside existing pinned versions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 65483d05-0d3b-4096-be7a-1d7263eba12a

📥 Commits

Reviewing files that changed from the base of the PR and between 2e00a33 and 9ca1d6d.

📒 Files selected for processing (1)
  • scripts/ci-ai-model-serving/tests/07-test-triton.sh

Walkthrough

A test script's Python dependency installation is updated to include gevent==24.2.1 alongside existing pinned packages for tritonclient and torchvision. No functional changes to test logic.

Changes

Cohort / File(s) Summary
CI Test Script Dependency
scripts/ci-ai-model-serving/tests/07-test-triton.sh
Added gevent==24.2.1 to virtualenv package installation alongside existing pinned dependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: pinning the gevent dependency version for AI model serving tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed The custom check validates Ginkgo test names, but the modified file is a bash shell script (07-test-triton.sh), not a Ginkgo test file, so the check does not apply.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code quality is not applicable to bash shell scripts; automatically passes.
Microshift Test Compatibility ✅ Passed Bash script test file with pip dependency addition is not a Ginkgo e2e test, making this check inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only a bash shell script for Python dependencies; no Ginkgo e2e tests are added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed Test script dependency pinning does not introduce scheduling constraints affecting SNO, Two-Node, HyperShift, or alternative topologies.
Ote Binary Stdout Contract ✅ Passed The check applies to OTE binaries' stdout management; this PR modifies a Bash CI script adding a Python dependency, not a Go binary, so the check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Custom check for Ginkgo e2e tests is not applicable; PR modifies only a bash shell script for Python dependency installation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@pacevedom: This pull request references USHIFT-6853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@pacevedom: This pull request references USHIFT-6853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Updated test environment dependencies to include an additional Python package alongside existing pinned versions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@pacevedom
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk
Copy link
Copy Markdown
Member

pmtk commented Apr 14, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2026
@pacevedom
Copy link
Copy Markdown
Contributor Author

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 14, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@pacevedom: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 0d63bcb into openshift:main Apr 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants