Fix GH-21691: OPcache CFG optimizer eliminates QM_ASSIGN feeding JMPZ with VAR operand#21696
Open
iliaal wants to merge 1 commit intophp:masterfrom
Open
Fix GH-21691: OPcache CFG optimizer eliminates QM_ASSIGN feeding JMPZ with VAR operand#21696iliaal wants to merge 1 commit intophp:masterfrom
iliaal wants to merge 1 commit intophp:masterfrom
Conversation
…MPZ with VAR operand The CFG optimizer (pass 5) removed a QM_ASSIGN that converted IS_VAR to IS_TMP_VAR before JMPZ. JMPZ has no handler for IS_VAR operands, producing "Invalid opcode 43/4/0." This occurred when ASSIGN_REF (which produces IS_VAR) fed into a conditional via QM_ASSIGN. Skip the QM_ASSIGN elimination when the source operand is IS_VAR. Closes phpGH-21691
Contributor
|
Confirm it fixes running test for Drupal, used as patch and tests pass https://git.drupalcode.org/project/drupal/-/jobs/9303090 |
dstogov
reviewed
Apr 13, 2026
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
The fix is right but incomplete.
The similar checks have to be added at least for ZEND_BOOL_NOT above and for ZEND_JMPN?Z_EX below.
I would add these IS_VAR checks into the conditions chains to avoid additional break. (but this is really not critical, and both decisions may have their advantages).
@iluuu1994 please also take a look. This is relate to ""VAR|TMP overhaul (GH-20628)"".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21691
The CFG optimizer (pass 5) removed a
QM_ASSIGNthat convertedIS_VARtoIS_TMP_VARbeforeJMPZ. SinceJMPZhas no handler forIS_VARoperands, this produced "Invalid opcode 43/4/0." The pattern occurs whenASSIGN_REF(which producesIS_VAR) feeds into a conditional viaQM_ASSIGN.Skips the
QM_ASSIGNelimination when the source operand isIS_VAR.