Skip to content

gh-148474: Fix _Py_hexlify_simd compilation with older clang #148475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmroot wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −1
Open

gh-148474: Fix _Py_hexlify_simd compilation with older clang #148475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbe143c
gh-148474: Fix _Py_hexlify_simd compilation with older clang
jmroot Apr 12, 2026
a376f71
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 12, 2026
ce91bec
Define four before nine
jmroot Apr 13, 2026
6799286
Update Misc/NEWS.d/next/Build/2026-04-12-22-54-16.gh-issue-148474.ouI…
picnixz Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2026-04-12-22-54-16.gh-issue-148474.ouIO8R.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed compilation of :file:`Python/pystrhex.c` with older clang versions.
3 changes: 2 additions & 1 deletion Python/pystrhex.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ _Py_hexlify_simd(const unsigned char *src, Py_UCS1 *dst, Py_ssize_t len)
const v16u8 mask_0f = v16u8_splat(0x0f);
const v16u8 ascii_0 = v16u8_splat('0');
const v16u8 offset = v16u8_splat('a' - '0' - 10); /* 0x27 */
const v16u8 four = v16u8_splat(4);
const v16s8 nine = v16s8_splat(9);

Py_ssize_t i = 0;
Expand All @@ -78,7 +79,7 @@ _Py_hexlify_simd(const unsigned char *src, Py_UCS1 *dst, Py_ssize_t len)
memcpy(&data, src + i, 16);

/* Extract high and low nibbles using vector operators */
v16u8 hi = (data >> 4) & mask_0f;
v16u8 hi = (data >> four) & mask_0f;
v16u8 lo = data & mask_0f;

/* Compare > 9 using signed comparison for efficient codegen.
Expand Down
Loading