Conversation
mattmkim
force-pushed
the
matthew.kim/parquet-janitor
branch
2 times, most recently
from
993d043 to
fa5eee3
Compare
mattmkim
changed the title
|
|
||
| /// Deletes a single batch of parquet splits from storage and metastore. | ||
| /// Returns (succeeded, failed). | ||
| async fn delete_parquet_splits_from_storage_and_metastore( |
There was a problem hiding this comment.
mimics logic in delete_splits_from_storage_and_metastore
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d08467270
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9979ce52d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 075f3e23d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mattmkim
force-pushed
the
matthew.kim/parquet-janitor
branch
from
075f3e2 to
63886de
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63886deccb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… retention config
mattmkim
force-pushed
the
matthew.kim/parquet-janitor
branch
from
63886de to
9c2262d
Compare
1 participant
Description
This PR can be reviewed commit by commit.
Enables the janitor to clean up parquet files, for metrics indexes. Functionally, should be the same as tantivy split cleanup.
How was this PR tested?
Describe how you tested this PR.