Fix default purchase correction to use recorded location instead of org default (5536)#5537
Open
cassxw wants to merge 1 commit intorubyforgood:mainfrom
Open
Fix default purchase correction to use recorded location instead of org default (5536)#5537cassxw wants to merge 1 commit intorubyforgood:mainfrom
cassxw wants to merge 1 commit intorubyforgood:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5536
Description
When correcting a purchase, the storage location dropdown was incorrectly defaulting to the organization's default storage location, instead of the location recorded on the existing purchase.
Root cause: The
default_locationhelper inApplicationHelperprioritizedcurrent_organization.default_storage_locationbefore checking the source object'sstorage_location_id.Fix: Reordered the logic to check the source object's
storage_location_idfirst, falling back to org defaults only when no location is recorded.Type of change
How Has This Been Tested?
spec/helpers/application_helper_spec.rb, verifying thatdefault_locationreturns the source object'sstorage_location_ideven when the organization has a different default.