fix(ui): stop terminal auto-select from stealing copilot input focus#4201
fix(ui): stop terminal auto-select from stealing copilot input focus#4201waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Also updates the chat stop-generation callbacks in Reviewed by Cursor Bugbot for commit 4677f01. Configure here. |
4677f01 to
53edd74
Compare
Greptile SummaryRemoves Confidence Score: 5/5Safe to merge — minimal, targeted change with no functional regression risk. The change removes a single No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[New console entry arrives] --> B{autoSelectEnabled?}
B -- No --> Z[No-op]
B -- Yes --> C[Set selectedEntryId to latest entry]
C --> D[Expand parent nodes if needed]
D --> E[Terminal visually highlights entry]
E --> F{Before fix: focusTerminal called?}
F -- Yes BEFORE --> G[terminalRef.focus - Steals focus from copilot textarea]
F -- No AFTER --> H[Focus stays on copilot textarea]
I[User clicks entry] --> J[handleSelectEntry]
J --> K[focusTerminal called explicitly]
K --> L[Terminal receives focus for keyboard nav]
Reviews (1): Last reviewed commit: "fix(ui): stop terminal auto-select from ..." | Re-trigger Greptile |
Summary
focusTerminal()call from terminal's auto-select effect so new console entries don't steal focus from the copilot textareaType of Change
Testing
Tested manually
Checklist