Open
Conversation
esbuild is only imported in build-time Vite plugin code (src/config/fs-routes/router.ts) and is never used by the production server output. Having it in dependencies causes unnecessary Docker image bloat (~9MB Go binary) and false-positive security scanner findings (Go stdlib CVEs in the esbuild binary). Closes solidjs#2135 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildfromdependenciestodevDependenciesinpackages/start/package.jsonMotivation
esbuildis only imported in build-time Vite plugin code (src/config/fs-routes/router.ts) and is never used by the production server output (.output/server/). Having it independenciescauses:npm ci --omit=devSince
vite(which itself depends onesbuild) is already apeerDependency, esbuild will always be available during the build step.Closes #2135
🤖 Generated with Claude Code