Skip to content

Fix supautils in authenticator session_preload_libraries #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samrose wants to merge 4 commits into
base: develop
Choose a base branch
from
+14 −6
Open

Fix supautils in authenticator session_preload_libraries #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7be11f3
fix: assure supautils on session_preload_libraries in authenticator role
samrose Apr 13, 2026
98a45cc
fix: expected output
samrose Apr 13, 2026
3ac856f
fix: quoting
samrose Apr 14, 2026
ea291c6
fix: regress tests
samrose Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions migrations/db/migrations/20260413000000_fix-authenticator-session-preload-libraries.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
-- migrate:up

-- The original fix in 20220224211803 checked pg_available_extensions for
-- supautils, but supautils is a preload library without a .control file,
-- so it never appears in pg_available_extensions. That migration was a no-op.
ALTER ROLE authenticator SET session_preload_libraries = supautils, safeupdate;

-- migrate:down
6 changes: 3 additions & 3 deletions nix/tests/expected/roles.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ select
from pg_roles r
where rolname not in ('pg_create_subscription', 'pg_maintain', 'pg_use_reserved_connections')
order by rolname;
rolname | rolconfig
----------------------------+---------------------------------------------------------------------------------
rolname | rolconfig
----------------------------+------------------------------------------------------------------------------------------
anon | {statement_timeout=3s}
authenticated | {statement_timeout=8s}
authenticator | {session_preload_libraries=safeupdate,statement_timeout=8s,lock_timeout=8s}
authenticator | {"session_preload_libraries=supautils, safeupdate",statement_timeout=8s,lock_timeout=8s}
dashboard_user |
pg_checkpoint |
pg_database_owner |
Expand Down
6 changes: 3 additions & 3 deletions nix/tests/expected/z_multigres-orioledb-17_roles.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ select
from pg_roles r
where rolname not in ('pg_create_subscription', 'pg_maintain', 'pg_use_reserved_connections')
order by rolname;
rolname | rolconfig
----------------------------+---------------------------------------------------------------------------------
rolname | rolconfig
----------------------------+------------------------------------------------------------------------------------------
anon | {statement_timeout=3s}
authenticated | {statement_timeout=8s}
authenticator | {session_preload_libraries=safeupdate,statement_timeout=8s,lock_timeout=8s}
authenticator | {"session_preload_libraries=supautils, safeupdate",statement_timeout=8s,lock_timeout=8s}
dashboard_user |
pg_checkpoint |
pg_database_owner |
Expand Down
Loading