Open
Conversation
Signed-off-by: Nicholas Gates <nick@nickgates.com>
AdamGS
reviewed
Apr 17, 2026
Comment on lines
+204
to
+205
| /// chunk. It must not wait for all segment I/O derived from this chunk to reach the underlying | ||
| /// file sink. |
Collaborator
There was a problem hiding this comment.
While obviously there's no way to enforce that data is persisted here, it does seem useful to the writer-facing API to be sure that the data isn't in memory anymore in some predictable way.
Collaborator
There was a problem hiding this comment.
Is the idea here that a user can push multiple chunks and then call flush to be sure that there's no more buffering?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the Vortex writer from streaming pull-based to push-based by default to better align with ecosystem APIs, and to allow for introspection of incremental progress to support file rotation and other similar use-cases.