Skip to content

Deprecate scalar_at for execute_scalar#7457

Merged
gatesn merged 5 commits intodevelopfrom
ngates/scalar_at
Apr 16, 2026
Merged

Deprecate scalar_at for execute_scalar#7457
gatesn merged 5 commits intodevelopfrom
ngates/scalar_at

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented Apr 15, 2026

No description provided.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2026

Merging this PR will degrade performance by 24.45%

⚡ 15 improved benchmarks
❌ 4 regressed benchmarks
✅ 1132 untouched benchmarks
🆕 2 new benchmarks
⏩ 1457 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation case_when_all_false[1000] 89.4 µs 104.8 µs -14.7%
Simulation case_when_fragmented[100] 122.4 µs 104.4 µs +17.25%
🆕 Simulation execute_scalar_struct_wide N/A 2.6 ms N/A
🆕 Simulation execute_scalar_struct_simple N/A 561.7 µs N/A
Simulation varbinview_zip_block_mask 3.7 ms 2.9 ms +27.61%
Simulation varbinview_zip_fragmented_mask 7.1 ms 6.4 ms +11.73%
Simulation new_alp_prim_test_between[f64, 32768] 253.1 µs 178.2 µs +42.06%
Simulation old_alp_prim_test_between[f32, 32768] 270.3 µs 240.2 µs +12.53%
Simulation new_bp_prim_test_between[i64, 32768] 179 µs 237 µs -24.45%
Simulation old_bp_prim_test_between[i32, 32768] 217.4 µs 247.8 µs -12.26%
Simulation old_alp_prim_test_between[f64, 32768] 349.6 µs 270.9 µs +29.05%
Simulation old_alp_prim_test_between[f64, 16384] 236.3 µs 197 µs +19.98%
Simulation old_bp_prim_test_between[i64, 16384] 187.3 µs 212.6 µs -11.88%
Simulation new_alp_prim_test_between[f64, 16384] 157.8 µs 119.9 µs +31.67%
Simulation new_alp_prim_test_between[f32, 16384] 120.9 µs 105.3 µs +14.88%
Simulation new_alp_prim_test_between[f32, 32768] 185.4 µs 155.5 µs +19.26%
Simulation old_bp_prim_test_between[i64, 32768] 328.9 µs 253.2 µs +29.89%
Simulation decompress_rd[f64, (10000, 0.0)] 275.6 µs 244.8 µs +12.55%
Simulation decompress_rd[f32, (10000, 0.0)] 245.5 µs 179.1 µs +37.06%
Simulation decompress_rd[f64, (10000, 0.01)] 275.1 µs 245.2 µs +12.18%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing ngates/scalar_at (627e496) with develop (ee2af71)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

gatesn added 2 commits April 15, 2026 18:24
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn added the changelog/break A breaking API change label Apr 15, 2026 — with ChatGPT Codex Connector
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn marked this pull request as ready for review April 15, 2026 23:25
@gatesn gatesn enabled auto-merge (squash) April 15, 2026 23:31
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/scalar_at branch from 911158a to 627e496 Compare April 16, 2026 02:16
@gatesn gatesn requested a review from joseph-isaacs April 16, 2026 02:25
@gatesn gatesn merged commit d992309 into develop Apr 16, 2026
59 of 60 checks passed
@gatesn gatesn deleted the ngates/scalar_at branch April 16, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants